[Fleet] Throw when enabling TDSB on an incompatible datastream #148540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
|
@elasticmachine merge upstream |
kpollich
approved these changes
Jan 9, 2023
x-pack/plugins/fleet/server/services/package_policies/experimental_datastream_features.test.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/fleet/server/services/package_policies/experimental_datastream_features.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Kyle Pollich <kpollich1@gmail.com>
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @nchaulet |
|
Replaced by #148553 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #141211 (comment)
To enable TDSB we need to have at least one dimension field.
The previous code was silently failing when the stream was not containing any dimension fields, this is confusing as the user, will not know about it.
That PR change that to explicitly throw when no dimension fields are provided.
UI Changes
cc @kpollich @ruflin